Add values_order key to getVocabularyValues for retaining manual sorting#160
Add values_order key to getVocabularyValues for retaining manual sorting#160JeffersonBledsoe wants to merge 2 commits intomasterfrom
Conversation
|
@JeffersonBledsoe thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
…t we can un-sort them if we want
davisagli
left a comment
There was a problem hiding this comment.
Instead of returning 2 different structures (one with the original order and one sorted by title) would it make sense to support vocabularies that specify their own custom sort function as an attribute? (which could be a no-op)
Adds a
values_orderkey to the return ofgetVocabularyValuesso that we can un-sort the titles should we want to.Fixes #161 without breaking the existing sorting