Conditional rendering testing value of object of forward/backward link#201
Draft
jg10-mastodon-social wants to merge 12 commits intomainfrom
Draft
Conditional rendering testing value of object of forward/backward link#201jg10-mastodon-social wants to merge 12 commits intomainfrom
jg10-mastodon-social wants to merge 12 commits intomainfrom
Conversation
jg10-mastodon-social
force-pushed
the
feat/conditional-values
branch
from
9c895fd to
243847e
Compare
| `); | ||
| }); | ||
|
|
||
| it('does not render templates when compareValue indicates that some-value-(lt|lte|gt|gte) is not met (numeric)', async () => { |
Collaborator
Author
There was a problem hiding this comment.
I suspect we might need more tests here, but I'm not sure how to design them.
I designed these as TDD tests - they all fail if the numbers are treated as strings.
| `); | ||
| }); | ||
|
|
||
| it('does not render templates when compareValue indicates that some-value-(lt|lte|gt|gte) is not met (string)', async () => { |
Collaborator
Author
There was a problem hiding this comment.
These tests were designed as TDD. By default compareValue returns true, so we test here that it returns false.
Given the default was to return true, I'm not sure it's possible to create failing tests, but it would be possible to write successful tests that show the code works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184