Box @Fetch* property wrappers in SwiftUI state when possible#486
Merged
Conversation
stephencelis
force-pushed
the
swiftui-state
branch
from
July 8, 2026 19:05
e52e73c to
558526c
Compare
* Use LockIsolated in FetchBox * fix * fix * Bump CI Xcode * Fix? * wip * Revert library test CI runner change * Smaller bump * fix --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some bugs with how the
@Fetch*family of property wrappers behave when view identity throughout the hierarchy changes, forcing theFetch*child value to be reconstructed in a bad state. E.g. a parent view might have some@Statedriving a@Bindingin a child view that also has a@FetchAll, and changing that@Statecan cause the@FetchAllto be inert and not render in the view.A fix for this has been to hold onto
@FetchAllin@State, but nested property wrappers are cumbersome to use, and in Xcode 27 it's not even possible due to@Statebecoming a macro.So instead, let's bake the
@Statedirectly inside the@Fetch*, preserving the data as the view hierarchy evolves.