Propagate suspension handling to CloudKit metadata#502
Open
phil1995 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SyncEnginealready includes iOS-specific lifecycle handling: it observesUIApplication.willResignActiveNotification, begins a background task, and attempts to send pending private and shared CloudKit changes before the app is suspended.watchOS does not use this integration and can suspend apps much more aggressively. GRDB supports this environment through the experimental flag
observesSuspensionNotifications, allowing clients to release database locks when postingDatabase.suspendNotification.However, while the user database can opt into this behavior,
SyncEnginemaintains a separate CloudKit metadata connection that does not currently participate. This can leave the metadata database holding a SQLite lock during suspension, resulting in aRUNNINGBOARD 0xdead10cctermination on watchOS.