Skip to content

Add SHA-pinned final-review status gate#120

Open
polymath-orchestrator wants to merge 3 commits into
mainfrom
ao/agent-orchestrator-85/final-review-status
Open

Add SHA-pinned final-review status gate#120
polymath-orchestrator wants to merge 3 commits into
mainfrom
ao/agent-orchestrator-85/final-review-status

Conversation

@polymath-orchestrator

@polymath-orchestrator polymath-orchestrator commented Jul 8, 2026

Copy link
Copy Markdown

Summary

  • Add ops/final-review-status.mjs plus tested core helpers for setting/checking a SHA-pinned GitHub commit status in context final-review.
  • Update the generated agent workflow contract so autonomous merge requires a current-head final-review success status with verdict=clean reviewer_family=<family> head=<sha>.
  • Document that ao native /sessions/{id}/reviews is a separate review system and must not be read as the final-review merge verdict.
  • Harden the checker to pick the newest status by timestamp, fail closed on same-timestamp conflicts, validate repo slugs, and validate SHA before API calls.

Verification

  • node --test ops/final-review-status.test.mjs
  • npm run test:ops
  • npm run agents:check
  • npx --yes prettier@3 --check .
  • git diff --check
  • GitHub checks green on 21c316ded3a19940dd62469e2eb0660251497131: Agent instructions, Frontend, Prettier, gitleaks
  • Final review: clean, reviewer_family=claude, head=21c316ded3a19940dd62469e2eb0660251497131; posted as final-review commit status and verified with node ops/final-review-status.mjs check ...
  • Review threads: none

Closes #114

@polymath-orchestrator polymath-orchestrator force-pushed the ao/agent-orchestrator-85/final-review-status branch from 349666b to 7c7baa3 Compare July 8, 2026 10:36
@polymath-orchestrator polymath-orchestrator marked this pull request as ready for review July 8, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

final-review must emit an authoritative machine-readable signal (verdict + head SHA) for the merge gate

1 participant