Skip to content

chore(release): prepare poi-plugin-ship-info@9.0.0-beta.0 - #615

Merged
KagamiChan merged 1 commit into
masterfrom
release/ship-info-a75b13cfdd7d-39069504001-1
Oct 17, 2026
Merged

KagamiChan merged 1 commit into
masterfrom
release/ship-info-a75b13cfdd7d-39069504001-1

Conversation

@cure-chiba

@cure-chiba cure-chiba Bot commented Oct 17, 2026

Copy link
Copy Markdown

This Release PR was generated by the Prepare release workflow.

Base commit: a75b13cfdd7d6dbea336ddb6de826add3c40d087
Selected packages:

  • poi-plugin-ship-info 8.1.1 -> 9.0.0-beta.0 (poi-plugin-ship-info@9.0.0-beta.0)

Generated files are recorded in release-plan.json. Do not edit this PR by
hand. If the base branch has advanced, close this PR and run Prepare
release again from the updated base; stale Release PRs are rejected.

Merging this PR publishes only the selected, validated tarballs through
npm trusted publishing after the release validation passes.

@petit-chiba petit-chiba Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review:

Found 1 actionable finding.

The Release PR records five change intents as consumed but leaves their .changeset/*.md files in the tree and omits their deletions from release-plan.json, so the required Release PR validation recompute cannot equal the plan.

Evidence:

  • .changeset/ledger.yaml:9-16 adds poi-plugin-ship-info@9.0.0-beta.0 with intents plugin-packaging-and-persistence, shared-package-and-ui-cleanup, ship-info-host-compatibility, ship-info-planner-extraction, ship-info-render-contracts, and packages/ship-info/CHANGELOG.md quotes every one of those intents' summaries. pnpm version -r only writes ledger entries/changelog bullets for intents it consumes, and consuming a changeset deletes its file (see tests/release-workflow.test.ts:290-304, where pnpmVersionSelection(root, ['ship-info']) removes the single-package ship-major.md while leaving the still-pending multi-package both-patch.md).
  • At the head revision 536d3d7, all five files still exist (e.g. .changeset/ship-info-planner-extraction.md, .changeset/ship-info-host-compatibility.md, .changeset/ship-info-render-contracts.md, plus the two ship-info/navy-staff files), and the PR diff contains no .changeset/*.md deletions.
  • The prior release at 9660642 shows the expected shape: its release-plan.json listed the consumed intents as {"status":"D"} (e.g. .changeset/navy-staff-interface-pages.md), and those deletions were committed.

Impact: validateReleasePr rebuilds the release in a detached worktree at the plan base with pnpmLaneVersionSelection and then requires the recomputed workingTreeChanges to equal plan.files byte-for-byte (scripts/release/lib.mjs:857-865, assertSameChanges(expectedChanges, plan.files, 'pnpm release plan')). Because pnpm deletes the three single-package ship-info intents (and, now that navy-staff is already at 2.0.0, the two multi-package ones as well), the recompute produces five D .changeset/*.md entries that release-plan.json:6-23 does not list. The check throws and the required status fails, so the Release PR can never merge as generated. If it were merged anyway, the ledger would declare the intents consumed while the files remain pending, so a later run would re-read already-consumed ids.

Smallest fix: do not hand-patch this. Close the PR and re-run Actions → Prepare release for ship-info/beta from the same base a75b13... so pnpm's own consumed-intent deletions are committed and included in release-plan.json (release-plan.json and .changeset/ledger.yaml must both be regenerated by the tooling, not edited).

@KagamiChan
KagamiChan merged commit f172d9f into master Oct 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant