Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jan 29, 2026

Copilot AI review requested due to automatic review settings January 29, 2026 21:10
@siddharthkp siddharthkp requested review from a team as code owners January 29, 2026 21:10
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026

⚠️ No Changeset found

Latest commit: baed8e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous change that added pr- namespaced utility classes for margin and padding. The decision was made to keep these namespaced styles in github/github-ui rather than in primer/css for safer migration in dotcom.

Changes:

  • Removes all pr- prefixed variants of margin utility classes (.pr-m*, .pr-mt*, .pr-mb*, .pr-mr*, .pr-ml*, .pr-mx*, .pr-my*)
  • Removes all pr- prefixed variants of padding utility classes (.pr-p*, .pr-pt*, .pr-pr*, .pr-pb*, .pr-pl*, .pr-px*, .pr-py*)
  • Removes the associated changeset file documenting the namespace addition

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/utilities/padding.scss Removes pr- namespaced variants of all padding utility classes, reverting to single-line formatting for most class definitions
src/utilities/margin.scss Removes pr- namespaced variants of all margin utility classes (including negative margins and auto margins), reverting to single-line formatting for most class definitions
.changeset/empty-islands-push.md Deletes the changeset that documented the addition of the pr- namespace for spacing utilities
Comments suppressed due to low confidence (1)

src/utilities/margin.scss:36

  • There's extra whitespace before the colon in the property declaration. The property should be margin-left: (without the extra space) for consistency with the rest of the codebase.
          .ml#{$variant}-n#{$scale} { margin-left  : calc(-1 * $size) !important; }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.pr-m#{$variant}-#{$scale} {
margin: $size !important;
}
.m#{$variant}-#{$scale} { margin: $size !important; }
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spaces between the selector and the opening brace. This should be a single space for consistency with the rest of the codebase (see other lines in this file and src/utilities/borders.scss which use single spaces).

Suggested change
.m#{$variant}-#{$scale} { margin: $size !important; }
.m#{$variant}-#{$scale} { margin: $size !important; }

Copilot uses AI. Check for mistakes.
margin-right: calc(-1 * $size) !important;
}

.mr#{$variant}-n#{$scale} { margin-right : calc(-1 * $size) !important; }
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's extra whitespace before the colon in the property declaration. The property should be margin-right: (without the extra space) for consistency with the rest of the codebase.

Suggested change
.mr#{$variant}-n#{$scale} { margin-right : calc(-1 * $size) !important; }
.mr#{$variant}-n#{$scale} { margin-right: calc(-1 * $size) !important; }

Copilot uses AI. Check for mistakes.
.pr-p#{$variant}-#{$scale} {
padding: $size !important;
}
.p#{$variant}-#{$scale} { padding: $size !important; }
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spaces between the selector and the opening brace. This should be a single space for consistency with the rest of the codebase (see other lines in this file and src/utilities/borders.scss which use single spaces).

Suggested change
.p#{$variant}-#{$scale} { padding: $size !important; }
.p#{$variant}-#{$scale} { padding: $size !important; }

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot temporarily deployed to Storybook Preview January 29, 2026 21:12 Inactive
@jonrohan jonrohan merged commit 9b99da7 into main Jan 29, 2026
25 checks passed
@jonrohan jonrohan deleted the revert-2962-namespace-layout branch January 29, 2026 21:19
@francinelucca francinelucca removed their request for review January 29, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants