GSOC-E2E: Add collections lifecycle test - #4248
Open
Geethegreat wants to merge 3 commits into
Open
Conversation
clairep94
reviewed
Aug 10, 2026
| .locator('button[aria-label="Close Add to collection overlay"]') | ||
| .click(); | ||
|
|
||
| await page.locator(`button:has-text("${testUser.username}")`).click(); |
Collaborator
There was a problem hiding this comment.
can we update to page.getByRole('menuitem', { name: ${testUser.username}` }).click();
or at least have the other selector methods be consistent throughout this file
6 tasks
clairep94
reviewed
Aug 17, 2026
Collaborator
There was a problem hiding this comment.
Let's unify how we do selectors on this test, you have a mixture of methods here:
page.locator('.editor-holder');
page.locator('button.editable-input__label')
page.getByRole('menuitem', { name: testUser.username })
page.locator('input#name')
page.getByRole('button', { name: 'Add to collection', exact: true })
etcetc
Collaborator
There was a problem hiding this comment.
I personally prefer page.getByRole for readability
I think some folks also prefer it as it tests accessibility
https://www.reddit.com/r/Playwright/comments/1m91faa/locator_or_getbyrole/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #
Adds a test that covers the full collections management lifecycle for an authenticated user.
Demo:
e2e-collections-1.mp4
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123