RHAIENG-2063: Consolidate cluster config objects to one RayCluster object

[kryanbeane]

Issue link

RHAIENG-2063

What changes have been made

Deprecated ManagedClusterConfig and ClusterConfiguration in favour of the new RayCluster object.

Verification steps

• Replace ManagedClusterConfig with RayCluster and Cluster(ClusterConfiguration()) iwth RayClutser in your selection of the demo notebooks and try them against an openshift cluster. You should be able to run the notebooks as normal.
• Fields like head_extended_resources_requests have been changed so be sure to check the new field names. See example below

config = RayCluster(
    name='test-cluster',
    namespace='default',
    head_cpu_requests='1',
    head_cpu_limits='2',
    head_memory_requests=6,
    head_memory_limits=8,
    num_workers=1,
    worker_cpu_requests='1',
    worker_cpu_limits='2',
    worker_memory_requests=4,
    worker_memory_limits=8,
    head_accelerators={'nvidia.com/gpu': 0},
    worker_accelerators={'nvidia.com/gpu': 0},
)

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[laurafitzgerald]

just one question inline, but overall this change looks great! It aligns the RayCluster configuration into one object while maintaining backwward compatibility for users who are still using Cluster(ClusterConfig).

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [laurafitzgerald]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci-robot]

@kryanbeane: This pull request references RHAIENG-2063 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Issue link

What changes have been made

Verification steps

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@kryanbeane: This pull request references RHAIENG-2063 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Issue link

RHAIENG-2063

What changes have been made

Deprecated ManagedClusterConfig and ClusterConfiguration in favour of the new RayCluster object.

Verification steps

• TODO

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

❌ Patch coverage is 85.08584% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.59%. Comparing base (b4b26b9) to head (940981d).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/codeflare_sdk/ray/rayclusters/lifecycle.py	72.04%	78 Missing ⚠️
...odeflare_sdk/ray/rayclusters/kubernetes_helpers.py	80.12%	33 Missing ⚠️
src/codeflare_sdk/ray/rayclusters/builders.py	94.91%	9 Missing ⚠️
src/codeflare_sdk/ray/rayclusters/test/conftest.py	71.42%	8 Missing ⚠️
...codeflare_sdk/common/widgets/raycluster_widgets.py	89.65%	6 Missing ⚠️
src/codeflare_sdk/ray/rayclusters/utils.py	93.05%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   95.91%   92.59%   -3.33%     
==========================================
  Files          22       30       +8     
  Lines        2130     3050     +920     
==========================================
+ Hits         2043     2824     +781     
- Misses         87      226     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.