feature: SCRUM-262 add init favorite artist view#30
Merged
gdaegeun539 merged 11 commits intoproject-lyrics:developfrom Mar 3, 2026
Merged
Conversation
Implement ArtistBubbleComponent to display favorite artists across different screens such as home, initial selection, and full list views. Add ArtistBubbleComponentData sealed interface to handle various states and UI variations. Include FindSquareIcon vector asset for the search button. - Add ArtistBubbleComponent with varying sizes and border styles - Create ArtistBubbleComponentData for different artist view types - Add find_square.xml vector drawable and expose it in Icons.kt
add private folder for ai prompt
- add ViewModel (OnboardingFavoriteArtistViewModel) - add view state (OnboardingFavoriteArtistViewState)
- moved loading indicator under the description text - remove click ripple at ArtistBubbleCompnent - add bottom gradient
- show artist favorite limit dialog
- add search with 1s debounce - add filter logic at viewmodel
- allow guard clause return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
SCRUM-262, 초기 온보딩 이후 관심 아티스트를 선택하는 화면이 없는 상황
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes
신규 화면과 컴포넌트만 추가합니다.
ScreenShots (If needed)
Other information:
라우팅은 다른 PR (i.e. #29 ) 을 머지한 이후 연결하겠습니다.