Skip to content

perf: remove redundant seen-Set deduplication in merge_entry_ranges #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartveneman merged 2 commits into from
Mar 17, 2026
Merged

perf: remove redundant seen-Set deduplication in merge_entry_ranges #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec4940
perf: remove redundant seen-Set deduplication in merge_entry_ranges
bartveneman Mar 17, 2026
30df4f0
Merge branch 'main' into perf/rm-redundant-checks
bartveneman Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/lib/decuplicate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,8 @@ function merge_entry_ranges(
return { url: entry.url, ranges: [...entry.ranges] }
}

let seen = new Set(sheet.ranges.map((r) => `${r.start}:${r.end}`))

for (let range of entry.ranges) {
let id = `${range.start}:${range.end}`
if (!seen.has(id)) {
seen.add(id)
sheet.ranges.push({ ...range })
}
sheet.ranges.push({ ...range })
}

return sheet
Expand Down
Loading