Repository navigation
Conversation
siavashs
marked this pull request as ready for review
October 6, 2026 13:23
TheMeier
approved these changes
Oct 9, 2026
SoloJacobs
approved these changes
Oct 9, 2026
SoloJacobs
left a comment
SoloJacobs
left a comment
There was a problem hiding this comment.
LGTM, some minor comments. I'm a bit sad that we can't fix the signature to just be correct, i.e.,
func New(handler http.Handler, cfg *Config) (*http.Server, error) {
siavashs
force-pushed
the
fix/configure-once-before-serve
branch
2 times, most recently
from
October 9, 2026 14:28
73ac568 to
da48107
Compare
|
LGTM, very nice ! the golanglint-ci issues seem pre-existing? |
Author
|
@SuperQ should we fix the |
ServeMultiple calls Serve concurrently for each listener on the same http.Server. Repeated setup can wrap the handler more than once and race when updating the handler and TLS configuration. Configure middleware and TLS once before starting listener goroutines. Preserve the public APIs and the existing wait-for-all return behavior. Signed-off-by: Siavash Safi <siavash@cloudflare.com>
siavashs
force-pushed
the
fix/configure-once-before-serve
branch
from
October 10, 2026 12:01
da48107 to
a28aa2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServeMultiple calls Serve concurrently for each listener on the same http.Server.
Repeated setup can wrap the handler more than once and race when updating the handler and TLS configuration.
Configure middleware and TLS once before starting listener goroutines.
Preserve the public APIs and the existing wait-for-all return behavior.