feat: add ordered list cycle command - #396
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds ChangesList cycling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/core/src/extensions/list.test.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/core/src/extensions/list.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
cyclePlainListto cycle plain blocks through bullet, ordered, and textState table
Task items are treated as non-plain-list content on the first press, so they convert to a plain bullet and clear stale task attrs instead of preserving checkbox semantics invisibly. Nested selections follow the existing closest-list convention used by
cycleCheckableList.Verification
pnpm test --run packages/core/src/extensions/list.test.tspnpm typecheckpnpm lintpnpm buildReflect dependency PR will wire the iOS toolbar button to this command.
Summary by CodeRabbit
New Features
Tests