Set and get the srgb colorspace from the output encoding. Due to deprecated outputEncoding#384
Open
danrossi wants to merge 3 commits into
Open
Set and get the srgb colorspace from the output encoding. Due to deprecated outputEncoding#384danrossi wants to merge 3 commits into
danrossi wants to merge 3 commits into
Conversation
…rds compatibility due to a depracted outputEncoding setter on three
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #267 #318
Due to the deprecated outputEncoding setter in three and a non existing export LinearEncoding.
This fix sets and gets the srgb outputColorSpace from the output encoding for backwards compatibility. This also sets a default outputColorSpace to Linear sgb.
Constants from three are included to prevent any further breaking change. I've imported the srgb colorspace constants from three which have been there for quite a few years now.