Add Windows conformance runner and testee support#28130
Open
dcodeIO wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Windows support for the conformance runner and C++ conformance testee. For the conformance runner, this splits
ForkPipeRunnerinto POSIX and Win32 implementations. The testee is switched to portableFILE*I/O, with binary mode on Windows.Also makes two related changes:
waitpid(..., WEXITED)is changed towaitpid(..., 0)becauseWEXITEDis awaitid()flag.waitpid(..., 0)already waits for the child to terminate.protobuf_configure_targetto the CMake conformance targets so they get the necessary target flags, e.g./utf-8, which is important on Windows.Otherwise wires the change into CI so the Windows target functionally mirrors the existing macOS target.
Resolves this existing Windows TODO in
fork_pipe_runner.cc: