Skip to content

chore(deps): bump glob to ^14.0.4 (clears 3 advisories; none reachable from Solhint) - #816

Open
vschernoff wants to merge 1 commit into
developfrom
deps/glob-14
Open

vschernoff wants to merge 1 commit into
developfrom
deps/glob-14

Conversation

@vschernoff

@vschernoff vschernoff commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Bumps glob from ^13.0.6 to ^14.0.4. One line in package.json, plus the lockfile.

Why

Several advisories in the production tree reach it through glob's own dependencies. npm audit --omit=dev on develop:

Package Severity Advisory
brace-expansion high seven DoS advisories, e.g. GHSA-6j4f-fj2g-mc7p (uncontrolled recursion in parseCommaParts) and GHSA-mh99-v99m-4gvg (unbounded expansion length)
glob moderate GHSA-3g3m-2fjr-6pw4 — AbortSignal cancellation bypass allows post-timeout filesystem traversal
minimatch moderate GHSA-g3hv-75wg-m249 — denial of service via globparts amplification

After this change all three packages are clean. The only advisory left is fast-uri, which #811 covers.

before:  3 moderate, 1 high  (brace-expansion, fast-uri, glob, minimatch)
after:   1 moderate          (fast-uri)

npm audit fix proposes solhint@6.1.0 instead — a downgrade of this package, not a fix.

Reachability — please don't read this as urgent

I don't think any of the three is exploitable through Solhint, and it would be wrong to let the word "high" imply otherwise.

  • The glob advisory needs an abort signal. Its root cause is abort branches in walker.ts calling cb() without returning, and every trigger it describes goes through signal or AbortSignal.timeout(). Solhint's only call is globSync(pattern, { nodir: true }) at solhint.js:187 — no signal, and signal appears nowhere else in the source. It is also availability-only (CWE-400, CVSS 6.3): "No confidentiality or integrity impact was observed."
  • The brace-expansion and minimatch advisories are pattern-driven — expansion blowups on a hostile glob pattern. The pattern here comes from the CLI arguments of whoever runs solhint, so reaching them means supplying a malicious pattern to your own run.

So the case for merging is a clean npm audit and current dependencies, not an exposure to fix. Treat it as housekeeping.

Why the bump is safe

glob 14 is a major release, so the usage was checked rather than assumed.

The CLI calls it in exactly one place, solhint.js:187:

const matchedFiles = globSync(pattern, { nodir: true })

No ignore option, no cwd, no signal. The v14 changes that affect callers are the leading-/ ignore semantics and ignore following windowsPathsNoEscape — neither applies, because no ignore option is passed. Excluded files are filtered separately through the ignore package a few lines down.

The remaining v14 change is minimatch 11 pattern matching. I compared globSync(pattern, { nodir: true }) under 13.0.6 and 14.0.4 over a fixture with nested directories, a dotfile, and a non-.sol file, across ten patterns:

contracts/**/*.sol, contracts/*.sol, **/*.sol, contracts/nested/**, src/**/*.sol, {contracts,src}/**/*.sol, contracts/**, ./contracts/**/*.sol, contracts/[AB]*.sol, contracts/**/[!d]*.sol

Results were identical for all ten.

engines is unaffected: glob 13.0.6 and 14.0.4 both declare node: 18||20||>=22.

Checks run

  • npm test — 1110 passing, 0 failing
  • eslint . — clean
  • CLI run on the fixture under both versions: same 12 findings, same files, same order

🤖 Generated with Claude Code

Clears three advisories in the production tree, all reaching it through
glob's own dependencies: brace-expansion (high), glob and minimatch
(moderate).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vschernoff vschernoff changed the title chore(deps): bump glob to ^14.0.4 chore(deps): bump glob to ^14.0.4 (clears 3 advisories; none reachable from Solhint) Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant