Repository navigation
chore(deps): bump glob to ^14.0.4 (clears 3 advisories; none reachable from Solhint) - #816
Open
vschernoff wants to merge 1 commit into
Open
vschernoff wants to merge 1 commit into
vschernoff wants to merge 1 commit into
Conversation
Clears three advisories in the production tree, all reaching it through glob's own dependencies: brace-expansion (high), glob and minimatch (moderate). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
globfrom^13.0.6to^14.0.4. One line inpackage.json, plus the lockfile.Why
Several advisories in the production tree reach it through glob's own dependencies.
npm audit --omit=devondevelop:brace-expansionparseCommaParts) and GHSA-mh99-v99m-4gvg (unbounded expansion length)globminimatchAfter this change all three packages are clean. The only advisory left is
fast-uri, which #811 covers.npm audit fixproposessolhint@6.1.0instead — a downgrade of this package, not a fix.Reachability — please don't read this as urgent
I don't think any of the three is exploitable through Solhint, and it would be wrong to let the word "high" imply otherwise.
walker.tscallingcb()without returning, and every trigger it describes goes throughsignalorAbortSignal.timeout(). Solhint's only call isglobSync(pattern, { nodir: true })atsolhint.js:187— nosignal, andsignalappears nowhere else in the source. It is also availability-only (CWE-400, CVSS 6.3): "No confidentiality or integrity impact was observed."solhint, so reaching them means supplying a malicious pattern to your own run.So the case for merging is a clean
npm auditand current dependencies, not an exposure to fix. Treat it as housekeeping.Why the bump is safe
glob 14 is a major release, so the usage was checked rather than assumed.
The CLI calls it in exactly one place,
solhint.js:187:No
ignoreoption, nocwd, nosignal. The v14 changes that affect callers are the leading-/ignoresemantics andignorefollowingwindowsPathsNoEscape— neither applies, because noignoreoption is passed. Excluded files are filtered separately through theignorepackage a few lines down.The remaining v14 change is minimatch 11 pattern matching. I compared
globSync(pattern, { nodir: true })under 13.0.6 and 14.0.4 over a fixture with nested directories, a dotfile, and a non-.solfile, across ten patterns:contracts/**/*.sol,contracts/*.sol,**/*.sol,contracts/nested/**,src/**/*.sol,{contracts,src}/**/*.sol,contracts/**,./contracts/**/*.sol,contracts/[AB]*.sol,contracts/**/[!d]*.solResults were identical for all ten.
enginesis unaffected: glob 13.0.6 and 14.0.4 both declarenode: 18||20||>=22.Checks run
npm test— 1110 passing, 0 failingeslint .— clean🤖 Generated with Claude Code