[CHAIN] refactor(ui): remove dead tokens from tailwind config#11533
Open
alejandrobailo wants to merge 1 commit into
Open
[CHAIN] refactor(ui): remove dead tokens from tailwind config#11533alejandrobailo wants to merge 1 commit into
alejandrobailo wants to merge 1 commit into
Conversation
Merge the duplicated 'animation' keys (the second silently overrode the first, disabling fade-in and friends), drop unused color tokens (action, unused prowler-*/system-* shades), unused keyframes (woosh, lineAnim, advance, dropArrow, accordion-*, slide-*), and remove the non-existent dark:bg-prowler-theme-midnight class from the attack paths node detail panel.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jun 10, 2026
pfe-nazaries
requested changes
Jun 16, 2026
| "50%": { left: "20%", width: "80%" }, | ||
| "100%": { left: "100%", width: "100%" }, | ||
| }, | ||
| dropArrow: { |
Contributor
There was a problem hiding this comment.
Give a second check if this is used on ui/styles/globals.css:408
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Part of Chained PRs
feat/heroui-shadcn-migrationChain Overview
Context
Before migrating components off HeroUI,
tailwind.config.jscarries dead weight that would otherwise be migrated for nothing: unused color tokens, unused keyframes, and a silent bug.Description
animationkey:extenddeclaredanimationtwice; in a JS object literal the second key silently overrides the first, soanimate-fade-in,fade-out,expand,slide-in/outandcollapsewere never generated. The two maps are now merged, keeping only animations with real usages. This restores the fade-in ofcomponents/scans/cli-import-banner.tsx(itsanimate-fade-inclass was a no-op until now).action,prowler.theme.{green,purple,orange,yellow},prowler.grey.*,prowler.green.*,prowler.{black,white}.900,system.info.*,system.warning.*,system.severity.{critical,medium}, and unusedsuccess/errorshades. Verified with repo-wide greps (including dynamic template-literal class construction — none found).accordion-down/up,advance,fade-out,slide-in/out,woosh,lineAnim,dropArrow.dark:bg-prowler-theme-midnightin the attack paths node detail panel referenced a token that never existed — removing it is a zero-visual-change cleanup.No component code is migrated in this PR; the HeroUI plugin and all used tokens remain untouched.
Steps to review
cd ui && pnpm run healthcheck— passes.pnpm run build— passes.git grep prowler-grey ui/) — no usages exist./scansCLI import banner now fades in; attack paths node detail sheet unchanged.Checklist
pnpm run typecheck/lint/formatpasspnpm run buildpassesfade-inanimationLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.