Skip to content

[CHAIN] refactor(ui): remove dead tokens from tailwind config#11533

Open
alejandrobailo wants to merge 1 commit into
feat/heroui-shadcn-migrationfrom
feat/heroui-migration-phase-0-tailwind-cleanup
Open

[CHAIN] refactor(ui): remove dead tokens from tailwind config#11533
alejandrobailo wants to merge 1 commit into
feat/heroui-shadcn-migrationfrom
feat/heroui-migration-phase-0-tailwind-cleanup

Conversation

@alejandrobailo

Copy link
Copy Markdown
Contributor

🔗 Part of Chained PRs

Main PR #11532
Feature branch feat/heroui-shadcn-migration
Phase 0 of 5 — Tailwind config cleanup
Depends on — (first in chain)

Chain Overview

feat/heroui-shadcn-migration
  ├── Fase 0: tailwind config cleanup        ← this PR
  ├── Fase 1: skeleton/divider/spacer/card → shadcn
  ├── Fase 2: form controls → shadcn
  ├── Fase 3: compound components + hooks → shadcn
  ├── Fase 4: remove HeroUI provider/plugin/dependency
  └── Fase 5: components/ui → components/shadcn reorg

Context

Before migrating components off HeroUI, tailwind.config.js carries dead weight that would otherwise be migrated for nothing: unused color tokens, unused keyframes, and a silent bug.

Description

  • Fix duplicate animation key: extend declared animation twice; in a JS object literal the second key silently overrides the first, so animate-fade-in, fade-out, expand, slide-in/out and collapse were never generated. The two maps are now merged, keeping only animations with real usages. This restores the fade-in of components/scans/cli-import-banner.tsx (its animate-fade-in class was a no-op until now).
  • Remove unused color tokens: action, prowler.theme.{green,purple,orange,yellow}, prowler.grey.*, prowler.green.*, prowler.{black,white}.900, system.info.*, system.warning.*, system.severity.{critical,medium}, and unused success/error shades. Verified with repo-wide greps (including dynamic template-literal class construction — none found).
  • Remove unused keyframes: accordion-down/up, advance, fade-out, slide-in/out, woosh, lineAnim, dropArrow.
  • Remove dead class: dark:bg-prowler-theme-midnight in the attack paths node detail panel referenced a token that never existed — removing it is a zero-visual-change cleanup.

No component code is migrated in this PR; the HeroUI plugin and all used tokens remain untouched.

Steps to review

  1. cd ui && pnpm run healthcheck — passes.
  2. pnpm run build — passes.
  3. Grep for any removed token (e.g. git grep prowler-grey ui/) — no usages exist.
  4. Visual check: /scans CLI import banner now fades in; attack paths node detail sheet unchanged.

Checklist

  • pnpm run typecheck / lint / format pass
  • pnpm run build passes
  • No behavior change beyond restoring the intended fade-in animation

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Merge the duplicated 'animation' keys (the second silently overrode the
first, disabling fade-in and friends), drop unused color tokens
(action, unused prowler-*/system-* shades), unused keyframes (woosh,
lineAnim, advance, dropArrow, accordion-*, slide-*), and remove the
non-existent dark:bg-prowler-theme-midnight class from the attack paths
node detail panel.
@alejandrobailo alejandrobailo requested a review from a team as a code owner June 10, 2026 17:13
@alejandrobailo alejandrobailo added the no-changelog Skip including change in changelog/release notes label Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3a7c0cb7-2886-41ae-9176-2e684056ee32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/heroui-migration-phase-0-tailwind-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread ui/tailwind.config.js
"50%": { left: "20%", width: "80%" },
"100%": { left: "100%", width: "100%" },
},
dropArrow: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give a second check if this is used on ui/styles/globals.css:408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Skip including change in changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants