Skip to content

feat: ✨ Make controller ctor constexpr #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ion098 wants to merge 1 commit into
base: develop-pros-4
Choose a base branch
from
Open

feat: ✨ Make controller ctor constexpr #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/pros/misc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class Controller {
* The ID of the controller (e.g. the master or partner controller).
* Must be one of CONTROLLER_MASTER or CONTROLLER_PARTNER
*/
explicit Controller(controller_id_e_t id);
explicit constexpr Controller(controller_id_e_t id): _id(id) {}

/**
* Checks if the controller is connected.
Expand Down
2 changes: 0 additions & 2 deletions src/devices/controller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ namespace pros {
inline namespace v5 {
using namespace pros::c;

Controller::Controller(pros::controller_id_e_t id) : _id(id) {}

std::int32_t Controller::is_connected(void) {
return controller_is_connected(_id);
}
Expand Down