Adding a cumulative energy check functions#212
Open
qnguyen345 wants to merge 12 commits intopvlib:mainfrom
Open
Adding a cumulative energy check functions#212qnguyen345 wants to merge 12 commits intopvlib:mainfrom
qnguyen345 wants to merge 12 commits intopvlib:mainfrom
Conversation
Member
|
@qnguyen345 can we rename the 10004 file to system_10004_ac_energy.csv? This will make this a little more in-line with the naming conventions in the data folder. |
kperrynrel
requested changes
Aug 15, 2024
Member
kperrynrel
left a comment
There was a problem hiding this comment.
Good first start! Made a couple of nitpicks in the docstrings and suggested updates to the main conversion function. Also we discussed adding an example to the example gallery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] Clearly documented all new API functions with PEP257 and numpydoc compliant docstrings.- [ ] Added new API functions todocs/api.rst.in
docs/whatsnewfor all changes. Includes link to the GitHub Issue with
:issue:`num`or this Pull Request with
:pull:`num`. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`).I created an energy.py script in the quality folder to check and correct cumulative data streams. This is the github link to the original issue and discussion https://github.com/pvlib/pvanalytics/issues/165