Skip to content

Comments

Clean multipatch domain#185

Draft
yguclu wants to merge 13 commits intomasterfrom
clean-multipatch-domain
Draft

Clean multipatch domain#185
yguclu wants to merge 13 commits intomasterfrom
clean-multipatch-domain

Conversation

@yguclu
Copy link
Member

@yguclu yguclu commented Feb 11, 2026

Require orientation of interfaces (ornt parameter) between patches in a multipatch domain when:

  • Creating an Interface object (from sympde.topology.basic)
  • Creating a Domain object (from sympde.topology.domain) using either join or from_file constructors

Moreover:

  • Make Connectivity.todict() store the orientation in the output dictionary, hence allowing Domain.export() to save that information to file
  • Add consistency checks when creating a MappedDomain object (from sympde.topology.mapping)
  • Clean up sympde.expr.evaluation and expand its docstrings
  • Clean up unit tests after changes:
    • sympde.expr.tests.test_expr
    • sympde.topology.tests.test_logical_expr
    • sympde.topology.tests.test_topology
  • Update library version to 0.20.0

Copy link
Collaborator

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a lot of cleaning!

I don't know if the PR should be merged as is, I just left a few comments for now

return r
obj = Basic.__new__(cls, expr, domain)

return obj
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check the type of obj here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written in the docstring, when evaluate=False is passed to the constructor, obj is an unevaluated TerminalExpr object.

When evaluate=True is passed to the constructor, obj is created by the eval method and its type may vary. I see now that the Returns section of its docstring is probably not correct, I am going to double check it ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants