Conversation
campospinto
reviewed
Feb 16, 2026
Collaborator
campospinto
left a comment
There was a problem hiding this comment.
Thanks, that's a lot of cleaning!
I don't know if the PR should be merged as is, I just left a few comments for now
| return r | ||
| obj = Basic.__new__(cls, expr, domain) | ||
|
|
||
| return obj |
Collaborator
There was a problem hiding this comment.
should we check the type of obj here ?
Member
Author
There was a problem hiding this comment.
As written in the docstring, when evaluate=False is passed to the constructor, obj is an unevaluated TerminalExpr object.
When evaluate=True is passed to the constructor, obj is created by the eval method and its type may vary. I see now that the Returns section of its docstring is probably not correct, I am going to double check it ASAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require orientation of interfaces (
orntparameter) between patches in a multipatch domain when:Interfaceobject (fromsympde.topology.basic)Domainobject (fromsympde.topology.domain) using eitherjoinorfrom_fileconstructorsMoreover:
Connectivity.todict()store the orientation in the output dictionary, hence allowingDomain.export()to save that information to fileMappedDomainobject (fromsympde.topology.mapping)sympde.expr.evaluationand expand its docstringssympde.expr.tests.test_exprsympde.topology.tests.test_logical_exprsympde.topology.tests.test_topology0.20.0