This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Fixed delays causing not to achieve low power after deepsleep#255
Open
arapostol wants to merge 1 commit intopycom:release-candidatefrom
Open
Fixed delays causing not to achieve low power after deepsleep#255arapostol wants to merge 1 commit intopycom:release-candidatefrom
arapostol wants to merge 1 commit intopycom:release-candidatefrom
Conversation
esp32/lteppp.h: added new machine state E_LTE_DEINIT esp32/lteppp.c: removed disabling PSM lteppp_deinit() changes lte state to E_LTE_DEINIT lteppp_deinit() removed sending setlpm command before disabling UART. This caused the state machine to wait for a response from modem and timeout, resulting in a delay. esp32/modlte.c: removed disabling PSM removed sending setlpm command before lteppp_deinit(). Sending commands to modem before disabling UART cause delays.
Contributor
|
Dear @arapostol, after looking at this PR, we speeded up LTE modem shutdown by simply not invoking the Many thanks for the impulse! With kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
esp32/lteppp.h: added new machine state E_LTE_DEINIT
esp32/lteppp.c: removed disabling PSM
lteppp_deinit() changes lte state to E_LTE_DEINIT
lteppp_deinit() removed sending setlpm command before disabling UART. This caused the state machine to wait for a response from modem and timeout, resulting in a delay.
esp32/modlte.c:
removed disabling PSM
removed sending setlpm command before lteppp_deinit(). Sending commands to modem before disabling UART cause delays.