This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Open
Conversation
peter-pycom
suggested changes
Nov 11, 2020
Contributor
peter-pycom
left a comment
peter-pycom
left a comment
There was a problem hiding this comment.
see one question inline. also please add a commit message that explains why we're doing this. what does it achieve and PR to FD:master
| // stop smart config with special event | ||
| xEventGroupSetBits(wifi_event_group, ESPTOUCH_SLEEP_STOP_BIT); | ||
| vTaskDelay(100/portTICK_PERIOD_MS); | ||
| } |
Contributor
There was a problem hiding this comment.
just checking, is it intentional that we do nothing if self_in is bool and False? Or should we set ESPTOUCH_STOP_BIT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.