Skip to content

Update Service Levels docs to match the current UI - #2459

Merged
adriangb merged 4 commits into
mainfrom
docs/slo-page-refresh
Sep 23, 2026
Merged

adriangb merged 4 commits into
mainfrom
docs/slo-page-refresh

Conversation

@adriangb

@adriangb adriangb commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Summary

Some statements in the Service Levels guide no longer match the Logfire UI. This PR corrects them:

  • Reliability history span. The guide said that the history defaults to the last 24 hours and that you choose a span only on the Burn rate view. Both views start with the full rolling window of the target, and the span choice (24 hours, 7 days when the window is longer than 7 days, or the full window) applies to both.
  • Investigating failures. The guide referred to an Investigate failing events button that opens Explore. The detail page now has Open in SQL Workbench and, for record-based targets, Open in Live view. Both use the range that you select by dragging across the chart, or the displayed range when there is no selection. SQL Workbench opens the failing records for a record-based target, or the metric rows for a metric-based target. When a burn-rate alert has fired, its row has an Investigate link that opens the chart around the most recent firing.
  • Histogram metrics. The guide said that a histogram target counts values below a threshold. You can choose which side of the threshold is good (Below is good or Above is good).
  • Infrastructure as Code. The released Terraform and Pulumi providers have an experimental logfire_slo resource. The Infrastructure as Code resource list and the Service Levels guide now mention it. The docs name the resource only and do not describe its attributes.

The changes do not touch the burn-rate tier section, which #2458 updates separately. The two PRs merge cleanly in either order.

Preview

I built both pages locally with the unified docs preview (make docs-serve flow), together with #2458. Both pages render, and every link on them resolves: the new links to Infrastructure as Code, SQL Workbench and Live view, the in-page anchors, and the Terraform, OpenTofu and Pulumi registry links. Please still check the hosted preview.

Review in cubic

@adriangb
adriangb marked this pull request as ready for review September 22, 2026 22:28

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread docs/guides/web-ui/service-levels.md Outdated
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 9d1f3474-fff2-4ac1-bc50-82376f68d45f

📥 Commits

Reviewing files that changed from the base of the PR and between 659c5e3 and 652999a.

📒 Files selected for processing (1)
  • docs/guides/web-ui/service-levels.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • pydantic/logfire (manual)
  • pydantic/pydantic-ai (manual)

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The documentation clarifies metric target semantics and lists the experimental logfire_slo resource for infrastructure-as-code management. It also documents reliability history views, available time spans, and links from chart selections and alerts to SQL Workbench or Live view.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 65299

The supplied material identifies no specific documentation error or broken link. A hosted preview was not available for verification, but no actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating the Service Levels documentation to match the current UI.
Description check ✅ Passed The description explains the documentation updates, including reliability history, investigation links, histogram thresholds, and the experimental resource.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@adriangb
adriangb enabled auto-merge (squash) September 23, 2026 00:22
@adriangb
adriangb merged commit 15b1e4e into main Sep 23, 2026
26 checks passed
@adriangb
adriangb deleted the docs/slo-page-refresh branch September 23, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant