Properly detect self.fail() as a terminating node in unittest.TestCase
#10770
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Pierre-Sassoulas
added
False Positive 🦟
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10770 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 176 176
Lines 19560 19560
=======================================
Hits 18775 18775
Misses 785 785
🚀 New features to boost your workflow:
|
Pierre-Sassoulas
changed the title
self.fail() as a terminating node in unittest.TestCase
Pierre-Sassoulas
approved these changes
Dec 6, 2025
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Great first issue @CodePapayas, this is going in 4.0.5 :)
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Dec 6, 2025
…minating node in ``unittest.TestCase`` (#10771) Properly detect 'self.fail()' as a terminating node in 'unittest.TestCase' (#10770) (cherry picked from commit c45fef7) Co-authored-by: Zachary Wilkins-Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix possibly-used-before-assignment false positive when using self.fail() in tests
Closes #10743