Open
Conversation
Avasam
approved these changes
Feb 11, 2026
henryiii
reviewed
Feb 11, 2026
Contributor
|
Ruff & mypy: Up to the maintainers, but I'd rather see #392 I'll bump them back in follow-up PRs anyway. |
lazka
force-pushed
the
fix-ci-somewhat
branch
2 times, most recently
from
09abf8a to
c00c632
Compare
Otherwise it installs the packages present at the time the installer was releases, which for some reason was broken the last time. Enable updates so the newest versions are used.
Upstream changed from \Z to \z in python/cpython@add0ca9
the platform strings are different there compared to the official CPython distributions, so just skip the test there.
Downgrade to a version which succeeds with the current code. This makes sure that new ruff/mypy releases don't break the CI. Feel free to fix things and update to newer versions.
Contributor
Author
|
dropping of py 3.9 on main broke things again. I'm having a hard time caring about any of this at this point though if CI is just ignored. |
06da572 bumped the minimum Python version without fixing the resulting ruff errors. Target 3.9 again to keep CI green.
Contributor
Author
|
and we are back |
Now tha 3.9 is no longer supported. 3.12 is the next supported version in Cygwin.
Things fail with git introspection failed: fatal: detected dubious ownership in repository at '/cygdrive/d/a/distutils/distutils' I don't know what the real problem is, but just ignore permissions to get things green.
In python/cpython@b9d4318 the logic was changed to no longer depend on sys.version for detecting the platform, so mocking it no longer works. Since get_host_platform() just forwards to sysconfig.get_platform(), there isn't much left to test, so just test that they return the same platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes here and there, see the commits for details.