Repository navigation
Correct clamp type annotations for callable formatters and None - #458
Open
lohitredddy wants to merge 1 commit into
Open
lohitredddy wants to merge 1 commit into
lohitredddy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clamp()documents callable formatters and aNoneinput, but its annotations reject both uses. For example, mypy rejectsclamp(1, format=intword, floor=1e6)andclamp(None)even though both already work at runtime.Changes proposed in this pull request:
strreturn type andNonecalls returnNone; clarify the existing behavior in the docstring.typing.assert_typeregression coverage alongside runtime assertions for those calls.The function body is unchanged. The new assertions produce three mypy errors against the original annotations and pass with this change.
Validation on Python 3.12:
--num-workers 0.git diff --check: passed.Other Python versions and the full pre-commit hook collection were not run.