Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 19, 2025

To be confident about free-threaded compatibility, it is recommended to test with pytest-run-parallel.

Something like:
% uvx --with=pytest-run-parallel pytest --iterations=8 --parallel-threads=auto

@cclauss cclauss added the dependencies Pull requests that update a dependency file label Nov 19, 2025
@cclauss cclauss force-pushed the pytest-run-parallel branch from f90fbfa to 699ed8b Compare November 19, 2025 21:11
Copy link
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing --iterations like this makes the tests for everyone run at least 8 times slower.

Rather than editing the global tox config, I'd rather see one test job set up to run with --parallel-threads=auto and not use --iterations.

I'd rather see more attention being paid to writing multithreaded tests that use a shared Compressor and Decompressor. Maybe take a look at google/brotli#1386 for inspiration.

By the way, for all this free-threaded support stuff, I'm very happy to do all the work rather than reviewing it. You'll just have to be a little more patient with me.

@ngoldbaum
Copy link
Contributor

I'm going to abort the test run here because it's still going after 1 hour.

@cclauss cclauss closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants