[mypyc] Fix unsupported imports for type annotations #20390
Merged
+35
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Dec 14, 2025
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
This looks great, thank you!
Contributor
Author
|
@hauntsaninja thanks for the review! If there is anything that's still blocking this from being merged please let me know. |
Collaborator
|
I just wanted to wait in case folks who know more about mypyc than me wanted to chime in :-) Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #18874 which broke certain imports of type annotations.
/cc @advait-dixit @JukkaL
Fixes mypyc/mypyc#1099
Fixes mypyc/mypyc#1167
Fixes #20365
Closes mypyc/mypyc#1100