Check config.ini is sorted with GitHub Actions#592
Conversation
I think this would be the better option. It would allow creating PRs using the Github UI only. |
|
I meant to say:
It uses the We could ditch the GitHub Actions file, but I think it's also useful if someone want to run it on their fork and they don't have pre-commit.ci enabled there. In both cases, PRs can be created via the UI. |
|
Ok, then let's do both 😃 |
malemburg
left a comment
There was a problem hiding this comment.
I don't have enough expertise to actually do a real review of the suggested Github actions, but the general approach is a good one (and because the repo needs an approving review, I added one).
|
@python/organization-owners Please could you add this repo to https://pre-commit.ci? Whilst we're here, if it's okay with @malemburg (anyone else I should ask?), I'll also volunteer for write permissions, then I can help with PRs like #587 :) |
Fine with me (I don't see a "Settings" button in the repo, though, so I guess I don't have permissions to give you write access). @matrixise used to manage the Planet for a longer while. Any thoughts on this ? |
Done. https://results.pre-commit.ci/repo/github/24216135
I've created a new @python/planet team and assigned the maintain role for this repo. @matrixise has been set as the maintainer of the team and can add existing users from the Python org. I've also added @malemburg and @hugovk as members of the team. |
|
Thanks, @ewdurbin |
|
Thanks all! |
Follow on from #591 where we discovered
config.iniwas no longer sorted.This PR runs
sort-ini.pyon the CI and will fail if there was a change.Here's an example failure: https://github.com/hugovk/planet/actions/runs/13658725429/job/38184489758
And an example pass: https://github.com/hugovk/planet/actions/runs/13658738341/job/38184533998
Optionally, we could enable https://pre-commit.ci/ on this repo and it will auto-update unsorted PRs.