Conversation
|
FYI |
|
Sorry, I missed it :) |
|
Diff from mypy_primer, showing the effect of this PR on open source code: pyppeteer (https://github.com/pyppeteer/pyppeteer)
+ pyppeteer/__init__.py:22: error: Argument 2 to "get" of "Mapping" has incompatible type "str | PathLike[str]"; expected "str" [arg-type]
|
|
( |
|
thank you, i got it. but i was just looking for a reason to send PR 😄 |
I get what you're saying (and am grateful for several of your recent PRs to typeshed!), but note this is a somewhat dangerous path. For instance, I find that mindset leads me away from prioritising working on contributions that would maximise impact or maximise my personal learning. In general, I find it a good principle to prioritise contributions that you know at least one real life human will find real life helpful. This also makes sure we make good use of the time of real life human reviewers! |
|
ok thanks, i was trying to find a library without type hints and forgot to check issues in this repo, so i'll focus on the fact that many stubs are not completed now 👍 |
PyPI | Github
it seems neither source code of lib nor the PR are being developed anymore (the last change in the code was 5 years ago and the PR about adding type stubs was sent 9 years ago)