Skip to content

Arm backend: Add SharedQspec tests #16937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AdrianLundell wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Arm backend: Add SharedQspec tests #16937

AdrianLundell wants to merge 2 commits into from
+647 −3

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Jan 28, 2026 •
edited by pytorch-bot bot
Loading

Adds Quantizer edge-case tests for operators using SharedQspec to lock down the behaviour and notice any changes.

Checks both qspecs and qparams to be extra rigorous.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@AdrianLundell
Arm backend: Add SharedQspec tests
f55eac2 
Adds Quantizer edge-case tests for operators using SharedQspec
to lock down the behaviour and notice any changes.

Checks both qspecs and qparams to be extra rigorous.

+ Type corrections for lintrunner

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: I1b7632c042fc926f2d3e8cbb24cade6e0b45c6ba
@AdrianLundell AdrianLundell requested a review from zingo January 28, 2026 14:30
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Jan 28, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 28, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16937

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit fafb0d2 with merge base a093fe4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdrianLundell @zingo