Skip to content

Revert pthreadpool a56dcd7 update (backout D104906625 + dependent D108226589) (#20521)#20521

Open
GregoryComer wants to merge 1 commit into
pytorch:mainfrom
GregoryComer:export-D109744957
Open

Revert pthreadpool a56dcd7 update (backout D104906625 + dependent D108226589) (#20521)#20521
GregoryComer wants to merge 1 commit into
pytorch:mainfrom
GregoryComer:export-D109744957

Conversation

@GregoryComer

@GregoryComer GregoryComer commented Jun 25, 2026 •
edited by meta-codesync Bot
Loading

Copy link
Copy Markdown
Member

Summary:

Revert the update to the third-party pthreadpool library, as it is suspected to have regressed performance on wearable PLLM/FLLM: S678566.

Differential Revision: D109744957

@pytorch-bot pytorch-bot Bot added the ci-no-td label Jun 25, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20521

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit eaf04ec with merge base bb28350 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2026
@meta-codesync

meta-codesync Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109744957.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer @facebook-github-bot
Revert pthreadpool a56dcd7 update (backout D104906625 + dependent D10…
eaf04ec 
…8226589) (pytorch#20521)

Summary:

Revert the update to the third-party pthreadpool library, as it is suspected to have regressed performance on wearable PLLM/FLLM: S678566.

Differential Revision: D109744957
@meta-codesync meta-codesync Bot changed the title Revert pthreadpool a56dcd7 update (backout D104906625 + dependent D108226589) Revert pthreadpool a56dcd7 update (backout D104906625 + dependent D108226589) (#20521) Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rascani rascani rascani approved these changes
@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner
@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner
@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees

No one assigned

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer @rascani