Don't link libdl when cross-compiling#20522
Draft
rascani wants to merge 2 commits into
Draft
Conversation
…ure)
The top-level CMakeLists.txt links libdl into executorch_core when
EXECUTORCH_USE_DL is on (the default):
find_library(DL_LIBRARY_EXISTS NAMES dl)
if(DL_LIBRARY_EXISTS): target_link_libraries(executorch_core PRIVATE dl)
When cross-compiling for a bare-metal target (arm-none-eabi, esp, zephyr),
find_library still resolves the *host* libdl, so -ldl is linked into
executorch_core and propagates through the exported target interface, failing
the bare-metal executor-runner link ("cannot find -ldl"). dladdr() (the only
reason for the link) is compiled out on those targets anyway (it's gated by the
ET_USE_LIBDL macro, which the CMake build never defines).
Two layers:
- Guard the link with `NOT CMAKE_CROSSCOMPILING` in CMakeLists.txt, so any
cross-compiled target is covered even without a preset.
- Set EXECUTORCH_USE_DL OFF explicitly in the arm_baremetal / esp_baremetal /
zephyr presets, documenting the intent for those bare-metal builds.
Confirmed against the cortex-m FVP runner: with -ldl removed the
arm_executor_runner links and runs on Corstone-300.
Co-authored-by: Claude <noreply@anthropic.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20522
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2edbd8a with merge base d523daa ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The top-level CMakeLists.txt links libdl into executorch_core when EXECUTORCH_USE_DL is on (the default):
When cross-compiling for a bare-metal target (arm-none-eabi, esp, zephyr), find_library still resolves the host libdl, so -ldl is linked into executorch_core and propagates through the exported target interface, failing the bare-metal executor-runner link ("cannot find -ldl"). dladdr() (the only reason for the link) is compiled out on those targets anyway (it's gated by the ET_USE_LIBDL macro, which the CMake build never defines).
Two layers:
NOT CMAKE_CROSSCOMPILINGin CMakeLists.txt, so any cross-compiled target is covered even without a preset.Test plan
Confirmed against the cortex-m FVP runner: with -ldl removed the arm_executor_runner links and runs on Corstone-300.