Skip to content

Arm backend: Keep INT delegate boundaries quantized - #22966

Merged
zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Keep-INT-delegate-boundaries-quantized
Sep 22, 2026
Merged

zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Keep-INT-delegate-boundaries-quantized

Conversation

@zingo

@zingo zingo commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

INT-only TOSA partitions could keep dequantize and floating-point operations inside a delegate at an output boundary. The delegate then wrote integer data into a buffer ExecuTorch described as FP32.

Without:

delegate [INT16 -> DQ -> split FP32] -> portable FP32

With:

delegate INT16 -> portable [DQ -> split FP32]

Remove Q/DQ and floating-point boundary nodes until an INT-only partition exposes integer buffers. This handles the supported Q/DQ variants for both INT8 and INT16 graphs.

Add a regression based on the shared split found in YOLO. Force BMM outside the delegate so the boundary remains stable if U55 gains INT16 BMM support.

Test plan

Run the regression on FVP with the portable runner. Add the portable split and BMM kernels needed by the test.

cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

INT-only TOSA partitions could keep dequantize and floating-point
operations inside a delegate at an output boundary. The delegate then
wrote integer data into a buffer ExecuTorch described as FP32.

Without:

  delegate [INT16 -> DQ -> split FP32] -> portable FP32

With:

  delegate INT16 -> portable [DQ -> split FP32]

Remove Q/DQ and floating-point boundary nodes until an INT-only
partition exposes integer buffers. This handles the supported Q/DQ
variants for both INT8 and INT16 graphs.

Add a regression based on the shared split found in YOLO. Force BMM
outside the delegate so the boundary remains stable if U55 gains INT16
BMM support.

Run the regression on FVP with the portable runner. Add the portable
split and BMM kernels needed by the test.

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: I51fb0e916fcf2b8a77d86d832c6acfcfddd63335
@zingo
zingo requested a review from digantdesai as a code owner September 21, 2026 12:47
@pytorch-bot

pytorch-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22966

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit f556a7b with merge base 3ffd297 (image):

NEW FAILURE - The following job has failed:

  • Cadence Build & Test / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Sep 21, 2026
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Sep 21, 2026
@zingo

zingo commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

Failed jobs are unrelated

@zingo
zingo merged commit 6cca16e into pytorch:main Sep 22, 2026
460 of 478 checks passed
@zingo
zingo deleted the Arm-backend-Keep-INT-delegate-boundaries-quantized branch September 23, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants