Skip to content

Honor lengths in merged named-data keys (#22977) - #22977

Open
estervojko wants to merge 1 commit into
mainfrom
export-D119537721
Open

Honor lengths in merged named-data keys (#22977)#22977
estervojko wants to merge 1 commit into
mainfrom
export-D119537721

Conversation

@estervojko

@estervojko estervojko commented Sep 21, 2026 •
edited by meta-codesync Bot
Loading

Copy link
Copy Markdown

Summary:

NamedDataMap keys are string_view values and are not required to be null terminated. Make merged-map lookup and logging honor the explicit key length, and fix an existing test comparison that compared a buffer with itself. Add coverage using a valid key followed by unrelated bytes.

Reviewed By: rascani

Differential Revision: D119537721

@pytorch-bot

pytorch-bot Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22977

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit ff5c413 with merge base ed72896 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: estervojko / name: Ester Vojkollari (d30d39a)

@meta-codesync

meta-codesync Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@estervojko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119537721.

rascani
rascani approved these changes Sep 21, 2026
View reviewed changes

@rascani rascani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Honor lengths in merged named-data keys Honor lengths in merged named-data keys (#22977) Sep 21, 2026
meta-codesync Bot pushed a commit that referenced this pull request Sep 21, 2026
@estervojko @facebook-github-bot
Honor lengths in merged named-data keys (#22977)
c180987 
Summary:

`NamedDataMap` keys are `string_view` values and are not required to be null terminated. Make merged-map lookup and logging honor the explicit key length, and fix an existing test comparison that compared a buffer with itself. Add coverage using a valid key followed by unrelated bytes.

Reviewed By: rascani

Differential Revision: D119537721
@meta-codesync meta-codesync Bot changed the title Honor lengths in merged named-data keys (#22977) Honor lengths in merged named-data keys Sep 22, 2026
@estervojko @facebook-github-bot
Honor lengths in merged named-data keys (#22977)
ff5c413 
Summary:

`NamedDataMap` keys are `string_view` values and are not required to be null terminated. Make merged-map lookup and logging honor the explicit key length, and fix an existing test comparison that compared a buffer with itself. Add coverage using a valid key followed by unrelated bytes.

Reviewed By: rascani

Differential Revision: D119537721
@meta-codesync meta-codesync Bot changed the title Honor lengths in merged named-data keys Honor lengths in merged named-data keys (#22977) Sep 22, 2026

This branch was successfully deployed

1 active deployment
cadence — ff5c4137 Deployed Sep 22, 2026 by meta-codesync[bot] via hifi-op-test / hifi4 #29188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rascani rascani rascani approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@estervojko @rascani