Update the rocm api filtering#1392
Closed
mwootton wants to merge 2 commits into
Closed
Conversation
|
|
|
@scotts has imported this pull request. If you are a Meta employee, you can view this in D104668141. |
scotts
reviewed
May 11, 2026
scotts
reviewed
May 11, 2026
Contributor
Author
|
2 bytes saved! Thanks, |
Contributor
|
@mwootton, thanks for the fix! No, unfortunately, we don't have a good linter solution yet. What I need to do is turn off the internal linter, and then rely on an external linter. We will just reuse the one that's used in PyTorch. That's on me to get that all working properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a list of chatty hip apis that are suppressed during rocm trace collection.
Updated an api name.
Added some new apis.
Removed some hipEvent apis we might want to see.