Update license definitions to include MIT and Dask's BSD3 #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not strictly needed and only confuses what license is used
And update versioneer
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 98.28% 98.28% -0.01%
==========================================
Files 6 6
Lines 759 758 -1
==========================================
- Hits 746 745 -1
Misses 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly closes #118. So in hindsight I should have just made this library BSD3 and it probably would have been simpler or at least less blurry. CC @QuLogic
This PR updates how the package metadata defines the license. I wanted this library to be MIT, not realizing at the time that dask was not MIT but BSD3. As far as I understand license headers are not necessary in each source file so I've removed the existing ones to avoid confusion about what license a particular source file was under. The copyright comment is also apparently optional under MIT and BSD3, but I've kept the copyright comments to make it more clear which files are from dask (Anaconda copyright) or created just for this library (Donfig copyright or no explicit copyright).
So in summary I think this library is defined as being MIT and BSD3 licensed. Code was and is taken from Dask and then put into Donfig. Since I'm keeping the original BSD3 license I'm not sure what that says about the license of the modified versions of that code.