Reland "Make symbol table order deterministic (#1263)"#1432
Merged
Conversation
quic-areg
force-pushed
the
deterministic-symtab
branch
from
July 16, 2026 19:04
64824c9 to
76659c9
Compare
quic-areg
marked this pull request as ready for review
July 17, 2026 20:23
quic-areg
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
July 17, 2026 20:23
quic-areg
force-pushed
the
deterministic-symtab
branch
from
July 17, 2026 20:24
76659c9 to
d2e673d
Compare
Shankar Easwaran (quic-seaswara)
approved these changes
Jul 17, 2026
quic-areg
force-pushed
the
deterministic-symtab
branch
from
July 21, 2026 16:24
d2e673d to
a12e175
Compare
Parth (parth-07)
approved these changes
Jul 21, 2026
quic-areg
force-pushed
the
deterministic-symtab
branch
from
July 23, 2026 17:40
a12e175 to
6672b48
Compare
quic-areg
force-pushed
the
deterministic-symtab
branch
2 times, most recently
from
July 23, 2026 19:35
d8c1191 to
f669dde
Compare
Shankar Easwaran (quic-seaswara)
requested changes
Jul 24, 2026
Shankar Easwaran (quic-seaswara)
approved these changes
Jul 24, 2026
Shankar Easwaran (quic-seaswara)
left a comment
Shankar Easwaran (quic-seaswara)
left a comment
Contributor
There was a problem hiding this comment.
please raise tickets for follow up.
Multithreaded relocation scanning made the order in which symbols were appended to the module symbol vector dependent on thread timing. Both .dynsym and .symtab inherited that order: existing sorts had address ties everywhere, and stable_sort fell back to the unpredictable insertion order. Sort each table deterministically by (input ordinal, input .symtab index). Also fixes a latent bug where an absolute symbol was not counted as global for computing sh_info. Fixes qualcomm#1261. This relands 257cefc, which was reverted in 3e0b10c. Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
quic-areg
force-pushed
the
deterministic-symtab
branch
from
July 24, 2026 21:04
f669dde to
4817640
Compare
quic-areg
added a commit
to quic-areg/eld
that referenced
this pull request
Jul 24, 2026
Follow-up to qualcomm#1432 which introduces a deterministic symbol table order. Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
Shankar Easwaran (quic-seaswara)
pushed a commit
that referenced
this pull request
Jul 24, 2026
Follow-up to #1432 which introduces a deterministic symbol table order. Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multithreaded relocation scanning made the order in which symbols were appended to the module symbol vector dependent on thread timing. Both .dynsym and .symtab inherited that order: existing sorts had address ties everywhere, and stable_sort fell back to the unpredictable insertion order.
Sort each table deterministically by (input ordinal, input .symtab index).
Also fixes a latent bug where an absolute symbol was not counted as
global for computing sh_info.
Fixes #1261.
This relands 257cefc, which was reverted in 3e0b10c.