Fix reproduce functionality for shared libraries with sysroot marker#1450
Merged
Parth (parth-07) merged 2 commits intoJul 24, 2026
Merged
Conversation
Parth (parth-07)
force-pushed
the
FixSharedLibWithSysrootMarkerForReproduce
branch
from
July 13, 2026 15:04
d64e676 to
fc93a16
Compare
Parth (parth-07)
requested review from
Steven Ramirez Rosa (Steven6798) and
Shankar Easwaran (quic-seaswara)
July 14, 2026 14:11
Steven Ramirez Rosa (Steven6798)
approved these changes
Jul 14, 2026
Parth (parth-07)
force-pushed
the
FixSharedLibWithSysrootMarkerForReproduce
branch
from
July 22, 2026 08:58
fc93a16 to
a134c7d
Compare
This commit fixes the --reproduce functionality so that command-line
shared libraries specified using a sysroot marker (e.g. =/lib.so)
works correctly.
The root cause was incorrect mapped path for non-namespec shared
libraries when the shared library was specified using the sysroot marker
(=). For a shared library, '=/lib1.so', the mapped path was the expanded
path '${SYSROOT}/lib1.so'. However, response.txt file contains the
lib1.so entry using 'rewritePath('=lib1.so')'. The rewritePath calls
returns 'lib1.so' as fallback because there is no entry for '=lib1.so'.
This is because '=lib1.so' entry was never added because we used incorrect
mapped path for non-namespec shared libraries (decoratedPath instead of the
command-line name used for everything else).
Resolves qualcomm#972
Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
Signed-off-by: Parth <partharora99160808@gmail.com>
Parth (parth-07)
force-pushed
the
FixSharedLibWithSysrootMarkerForReproduce
branch
from
July 24, 2026 03:17
08e0ea5 to
eb1b109
Compare
Shankar Easwaran (quic-seaswara)
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the --reproduce functionality so that command-line shared libraries specified using a sysroot marker (e.g. =/lib.so) works correctly.
The root cause was incorrect mapped path for non-namespec shared libraries when the shared library was specified using the sysroot marker (=). For a shared library, '=/lib1.so', the mapped path was the expanded path '${SYSROOT}/lib1.so'. However, response.txt file contains the lib1.so entry using 'rewritePath('=lib1.so')'. The rewritePath calls returns 'lib1.so' as fallback because there is no entry for '=lib1.so'. This is because '=lib1.so' entry was never added because we used incorrect mapped path for non-namespec shared libraries (decoratedPath instead of the command-line name used for everything else).
Resolves #972