Open
Conversation
reitermarkus
force-pushed
the
update-smoltcp
branch
6 times, most recently
from
09c1fad to
295aacf
Compare
reitermarkus
force-pushed
the
update-smoltcp
branch
from
295aacf to
db1a4b7
Compare
Contributor
Author
|
I saw #441, but it seems this needs to be fixed in |
jordens
requested changes
May 5, 2025
Member
I think so, yes. |
reitermarkus
force-pushed
the
update-smoltcp
branch
from
db1a4b7 to
a5c4797
Compare
Closed
reitermarkus
force-pushed
the
update-smoltcp
branch
2 times, most recently
from
7fd24c6 to
16472de
Compare
reitermarkus
force-pushed
the
update-smoltcp
branch
2 times, most recently
from
971ed71 to
fc219a1
Compare
jordens
reviewed
Mar 23, 2026
Member
jordens
left a comment
jordens
left a comment
There was a problem hiding this comment.
LGTM. Let's change the git url and take the current git nal, then land this.
We probably should land smoltcp 0.13 nal support sooner rather than later.
reitermarkus
force-pushed
the
update-smoltcp
branch
3 times, most recently
from
9428ebc to
f26a363
Compare
reitermarkus
force-pushed
the
update-smoltcp
branch
from
f26a363 to
857b5ca
Compare
reitermarkus
commented
Apr 9, 2026
Comment on lines
+94
to
+103
| // FIXME: No `self` here. | ||
| // | ||
| // Verify the interlock is mappable to a DAC threshold. | ||
| // let dac_voltage = self | ||
| // .output_power_transform | ||
| // .invert(*self.output_interlock_threshold); | ||
| // let dac_voltage_clamped = dac_voltage.clamp(0.0, ad5627::MAX_VOLTAGE); | ||
| // if dac_voltage_clamped != dac_voltage { | ||
| // *self.output_interlock_threshold = self.output_power_transform.map(dac_voltage_clamped); | ||
| // } |
Contributor
Author
There was a problem hiding this comment.
@jordens, not sure how to migrate this from #[tree(validate=...)].
Contributor
Author
|
Also had to update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs a rebase after #484 is merged.