Open
Conversation
Contributor
saghul
commented
Mar 3, 2026
saghul
commented
- Validate save index in lre_exec_backtrack
- Validate opcodes in lre_byte_swap
saghul
force-pushed
the
worktree-lre-fixes
branch
from
abd554b to
240c6f8
Compare
saghul
force-pushed
the
worktree-lre-fixes
branch
from
240c6f8 to
5ae4562
Compare
bnoordhuis
approved these changes
Mar 3, 2026
Fixes: #1375 Replace assert() with runtime check for REOP_save_start/REOP_save_end/ REOP_save_reset capture indices. Also add lre-test with a test for this issue, and the starting point for more lre tests.
Fixes: #1376 Check that opcode bytes are < REOP_COUNT before indexing into the reopcode_info array. Also change lre_byte_swap to return int (-1 on error, 0 on success) instead of aborting, and handle the error gracefully.
saghul
force-pushed
the
worktree-lre-fixes
branch
from
5ae4562 to
561d927
Compare
Contributor
Author
|
@bnoordhuis Can you PTAL? I added the extra error constant and checking, plus handling of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.