feat(IDPLATF-6508): remove JWT validation, parse-only#14
Open
rodrigo-rufino wants to merge 5 commits into
Open
feat(IDPLATF-6508): remove JWT validation, parse-only#14rodrigo-rufino wants to merge 5 commits into
rodrigo-rufino wants to merge 5 commits into
Conversation
Co-authored-by: Ana Beatriz Cuelbas <54193070+anabcuelbas@users.noreply.github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
JWT validation is now handled at the infrastructure level by Istio, so tokens always arrive at the application already validated. Keeping validation inside the library required each service to hold a reference to the signing public key, which blocked key rotation and added unnecessary coupling to the auth infrastructure. Removing signature verification is a breaking change for any caller that relied on
InvalidJwtExceptionbeing thrown, which warrants a major version bump (2.0.0).What
QuintoAndarJwtBeanandQuintoAndarKeycloakJwtBeanjose4jandcommons-iodependencies frombuild.gradleQuintoAndarPublicKeyService,QuintoAndarKeycloakPublicKeyService,SetupException,QuintoandarPropertiesgetPayload()no longer declaresthrows InvalidJwtExceptionHow
Base64.getUrlDecoder()and Jackson'sObjectMapperQuintoAndarJwtAutoConfigurationREADME.md