馃崐 Sprint Clementine - #30
Open
r002 wants to merge 1 commit into
Open
Conversation
馃帹 Add thumbnail to YoutubeLogs
|
Visit the preview URL for this PR (updated for commit 7ae4e61): https://captains-log--pr30-sprint-clementine-wg8ervzh.web.app (expires Fri, 09 Apr 2021 01:11:46 GMT) 馃敟 via Firebase Hosting GitHub Action 馃寧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this branch, I played around with the idea of embedding YT vid thumbnails directly in the logs themselves. But I'm unhappy with the ascetics. (TW thinks the thumbnails uglifies everything too!) So I'm discarding this layout. Will keep this PR around though just for future reference.
Also, FWIW, note-to-self: Get better at design! An ideal future state would be to mock everything up in PS first and then just implement that version. We'll get there. Eventually. 馃槄 Right now, am still in a kinda "exploration/learning" phase and experimenting with different things. Eg. Even if this sprint didn't ultimately contribute to
main, by doing it, I learned all about the YouTube V3 Data API.Resources:
Rejected!