Support cross database inserts#1357
Merged
Merged
Conversation
|
@aidanharan I think to make an eventually passing test the SQL needs to change to this chrisortman@bfb3cb9 |
Fix sql Use database when constructing object ID argument Wrap insert in transaction Update temp_test_sqlserver.rb Update temp_test_sqlserver.rb Update temp_test_sqlserver.rb Update temp_test_sqlserver.rb Timeout CI tests after 10 minutes Update temp_test_sqlserver.rb Verbose Debug Update temp_test_sqlserver.rb Debug Update temp_test_sqlserver.rb Debug Cleanup Update adapter_test_sqlserver.rb Update adapter_test_sqlserver.rb Update adapter_test_sqlserver.rb Update adapter_test_sqlserver.rb
aidanharan
force-pushed
the
insert-different-schema-7.2
branch
from
abd0ab6 to
ee9b042
Compare
aidanharan
changed the title
Contributor
Author
|
@chrisortman: Would you mind reviewing the following PR? I tried to add a test that performed a |
chrisortman
approved these changes
Aug 15, 2025
chrisortman
left a comment
chrisortman
left a comment
There was a problem hiding this comment.
This looks great. Thank you for working on this.
aidanharan
added a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1355
When finding the column information of a table, include the database when calculating the table's
object_id. Otherwise the database is assumed to be the connection's default database.Ref: https://learn.microsoft.com/en-us/sql/t-sql/functions/object-id-transact-sql?view=sql-server-ver17