Fix JS challenge on youtube download#310
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 31: Update the install experience to account for yt-dlp-ejs's JS runtime
dependency: in pyproject.toml we added "yt-dlp[default]" but you must also (A)
add a runtime check and optional installer in the ./install/ CPU and CUDA
scripts that detect a JavaScript engine (check for deno, node, bun, or
qjs/quickjs) and install a supported runtime (or exit with a clear message and
installation hint) and (B) update README.md to document the requirement and show
recommended install commands for at least one supported runtime (e.g., node or
deno) and link to alternatives, so users won’t hit the "No supported JavaScript
runtime could be found" error.
Fixes #305.
Beware that this will conflict with the generated uv.lock in my separate PR, so if this is merged then uv.lock needs to be regenerated.
Summary by CodeRabbit