Skip to content

Fix JS challenge on youtube download#310

Merged
rakuri255 merged 2 commits into
rakuri255:mainfrom
magicus:fix-yt-dlp-deno
Mar 4, 2026
Merged

Fix JS challenge on youtube download#310
rakuri255 merged 2 commits into
rakuri255:mainfrom
magicus:fix-yt-dlp-deno

Conversation

@magicus

@magicus magicus commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #305.

Beware that this will conflict with the generated uv.lock in my separate PR, so if this is merged then uv.lock needs to be regenerated.

Summary by CodeRabbit

  • Chores
    • Updated yt-dlp dependency to include default extras for improved video download support.
    • Added Deno as a new runtime dependency to support additional tooling and workflows.

@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0c5493 and 51e0111.

📒 Files selected for processing (1)
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

The PR updates pyproject.toml: the yt-dlp dependency is changed to yt-dlp[default], and a new deno dependency entry is added. No other configuration or code changes.

Changes

Cohort / File(s) Summary
Dependency manifest
pyproject.toml
Changed yt-dlpyt-dlp[default] and added a new deno dependency entry to enable a supported JavaScript runtime for yt-dlp's extraction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped into toml with care,
I added deno, fixed the air,
yt-dlp now brings its friends,
So YouTube pulls reach happy ends. 🎶

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix JS challenge on youtube download' directly relates to the main change - adding deno as a dependency to resolve yt-dlp's JavaScript runtime requirement for YouTube downloads.
Linked Issues check ✅ Passed The PR adds deno as a dependency to resolve issue #305, which required installing a JavaScript runtime for yt-dlp's YouTube extraction functionality.
Out of Scope Changes check ✅ Passed The PR contains only two scope-related changes: updating yt-dlp to yt-dlp[default] and adding deno as a dependency, both directly addressing the linked issue #305.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Line 31: Update the install experience to account for yt-dlp-ejs's JS runtime
dependency: in pyproject.toml we added "yt-dlp[default]" but you must also (A)
add a runtime check and optional installer in the ./install/ CPU and CUDA
scripts that detect a JavaScript engine (check for deno, node, bun, or
qjs/quickjs) and install a supported runtime (or exit with a clear message and
installation hint) and (B) update README.md to document the requirement and show
recommended install commands for at least one supported runtime (e.g., node or
deno) and link to alternatives, so users won’t hit the "No supported JavaScript
runtime could be found" error.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e07cb90 and d0c5493.

📒 Files selected for processing (1)
  • pyproject.toml

Comment thread pyproject.toml

@rakuri255 rakuri255 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@rakuri255 rakuri255 merged commit d828a0f into rakuri255:main Mar 4, 2026
4 checks passed
@magicus magicus deleted the fix-yt-dlp-deno branch March 8, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yt-dlp: No supported JavaScript runtime could be found

2 participants