Fix stale .attach_pid files left in cwd if target process dies before attachment completes in Hotspot#1883
Open
Krishnapriya-RS94 wants to merge 1 commit intoraphw:masterfrom
Open
Conversation
… attachment in Hotspot
Owner
|
Instead of moving this to a method, could you just add a line with: Wrap this in an try-catch block for IOException and ignore the exception, as resolving a canonical file can fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports OpenJDK below fixes to prevent stale .attach_pid files from being left in application current working directories.
JDK-8214300
JDK-8228343
Why
When attaching to a JVM process using the HotSpot attach mechanism, ByteBuddy creates an .
attach_pid<pid>file in the target process's current working directory (accessed via/proc/<pid>/cwd/). If the target process dies or crashes after the attach file is created but before the attachment completes, the cleanup in the finally block fails because/proc/<pid>/cwd/symlink disappears when the process dies..attach_pidfile orphaned in the application's working directoryHow
This PR implements the same fix used in OpenJDK:
/proc/<pid>/cwd/symlink (container-safe, perJDK-8228343)/proc/<pid>/disappears)Example:
Application running in:
/opt/app/myapp/Attach file created:
/proc/12345/cwd/.attach_pid12345 → /opt/app/myapp/.attach_pid12345Process 12345 dies →
/proc/12345/disappearsCleanup tries:
/proc/12345/cwd/.attach_pid12345(fails - symlink gone)Result:
/opt/app/myapp/.attach_pid12345remains as stale fileBackported OpenJDK fixes:
Fix: Use canonical path for cleanup
JDK-8214300
Commit: ec1f0263
Fix: Attach failure for target container processes if canonical path is used for file creation
JDK-8228343
PR: #4418