fix: [avatar] fix group overlap, remove disabled, forward props - #923
Open
rohanchkrabrty wants to merge 2 commits into
Open
rohanchkrabrty wants to merge 2 commits into
rohanchkrabrty wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
An avatar is not interactive. The variant never received the prop, so disabled only leaked onto the span as an attribute.
rohanchkrabrty
changed the title
Shreyag02
approved these changes
Sep 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AvatarGroupoverlap rules. They used.avatar-size-N .avatarWrapper, which never matched, so every size got the default overlap. They now use.avatarWrapper:has(.avatar-size-N).disabledvariant. An avatar is not interactive, and the variant never received the prop, sodisabledonly reached the root as an attribute. Code that passesdisablednow gets a type error.onLoadingStatusChangeto the Base UI image, and addfallbackDelayfor the fallbackdelay.renderand in array children, so the overflow avatar matches an avatar inside aTooltip.Children.mapinstead of the array index. Add a Group section to the docs.Closes #597