fix(pipeline): add missing mutex locks in matrix executor#556
Open
nextlevelshit wants to merge 1 commit intomainfrom
Open
fix(pipeline): add missing mutex locks in matrix executor#556nextlevelshit wants to merge 1 commit intomainfrom
nextlevelshit wants to merge 1 commit intomainfrom
Conversation
aggregateResults() and the zero-items code path wrote to execution.Results and execution.WorkspacePaths without holding execution.mu. This could cause data corruption during concurrent matrix execution. Apply the same locking pattern used in concurrency.go.
nextlevelshit
force-pushed
the
fix-matrix-race-condition
branch
from
1a0d864 to
ff28059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aggregateResults()and the zero-items code path inmatrix.gowrote toexecution.Resultsandexecution.WorkspacePathswithout holdingexecution.muexecution.mu.Lock()/Unlock()pattern used inconcurrency.goTest plan
go test -race ./internal/pipeline/passesgo test ./...passes