Skip to content

Commit bf1258e

Browse files
coadometa-codesync[bot]
authored andcommitted
Make Image component implementation headers for-frameworks (#58875)
Summary: Pull Request resolved: #58875 Lower `ImageComponentDescriptor.h`, `ImageShadowNode.h`, `ImageProps.h`, `ImageState.h` and `ImageEventEmitter.h` in `react/renderer/components/image` from public to "for frameworks". They implement the built-in `<Image>` component and are consumed by hosts that register core components and by platform image renderers, not by app code. This matches the tiering of the `text`, `scrollview` and `root` component modules. `conversions.h` stays public and is now the only header in the `<React/Image.h>` umbrella: code generated for a component with an `ImageSource` prop includes `<React/Image.h>` and relies on its `fromRawValue(..., ImageSource &)` overload through `convertRawProp`. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123593354 fbshipit-source-id: 6dc40b2ff027fa344e6138db50d0477f21213369
1 parent a96d7fe commit bf1258e

6 files changed

Lines changed: 5 additions & 10 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/components/image/ImageComponentDescriptor.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <memory>
1313

‎packages/react-native/ReactCommon/react/renderer/components/image/ImageEventEmitter.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <cstdint>
1313

‎packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <optional>
1313
#include <string>

‎packages/react-native/ReactCommon/react/renderer/components/image/ImageShadowNode.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <memory>
1313

‎packages/react-native/ReactCommon/react/renderer/components/image/ImageState.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <memory>
1313
#include <utility>

‎packages/react-native/ReactCommon/react/renderer/components/image/React/Image.h‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@
3131
#undef RN_UMBRELLA_CONTEXT
3232
#define RN_UMBRELLA_CONTEXT 1
3333

34-
#include <react/renderer/components/image/ImageComponentDescriptor.h>
35-
#include <react/renderer/components/image/ImageEventEmitter.h>
36-
#include <react/renderer/components/image/ImageProps.h>
37-
#include <react/renderer/components/image/ImageShadowNode.h>
38-
#include <react/renderer/components/image/ImageState.h>
3934
#include <react/renderer/components/image/conversions.h>
4035

4136
#undef RN_UMBRELLA_CONTEXT

0 commit comments

Comments
 (0)