Skip to content

fix(iOS): reset accessibilityViewIsModal on view recycle to avoid trapping VoiceOver #57196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doracawl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(iOS): reset accessibilityViewIsModal on view recycle to avoid trapping VoiceOver #57196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51c53b7
fix(iOS): reset accessibilityViewIsModal on view recycle
doracawl Jun 13, 2026
c4ab261
fix(iOS): reset accessibility state on view recycle
doracawl Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,53 @@ - (void)prepareForRecycle
_removeClippedSubviews = NO;
_reactSubviews = [NSMutableArray new];
_layoutMetrics = {};

// Reset accessibility state so it does not leak across recycled views.
// updateProps writes most accessibility properties only when
// (oldProps != newProps); after recycle _props is reset to the
// AccessibilityProps default-constructed values, so any UIKit-side
// state previously set stays stale unless cleared here.
//
// The most visible failure this guards against is
// `accessibilityViewIsModal` / `accessibilityElementsHidden` trapping
// VoiceOver against a now-unrelated subtree (empty accessibility
// tree).
//
// Skipped on purpose:
// * `isAccessibilityElement` and `accessibilityTraits` — their
// UIKit defaults depend on the underlying view subclass
// (UIControl / UILabel / UIImageView start with different
// defaults than UIView). For RCTText/Image ComponentView
// `accessibilityElement` resolves to an inner UILabel /
// UIImageView whose natural a11y behavior would be clobbered
// by forcing NO / None here. Per-subclass reset is a separate
// follow-up.
self.accessibilityElement.accessibilityLabel = nil;
self.accessibilityElement.accessibilityLanguage = nil;
self.accessibilityElement.accessibilityHint = nil;
self.accessibilityElement.accessibilityValue = nil;
self.accessibilityElement.accessibilityViewIsModal = NO;
self.accessibilityElement.accessibilityElementsHidden = NO;
// UIView default for accessibilityRespondsToUserInteraction is YES.
self.accessibilityElement.accessibilityRespondsToUserInteraction = YES;
self.accessibilityIgnoresInvertColors = NO;
// Clear only the `accessibilityState` bits the setter writes via
// self.accessibilityTraits (.NotEnabled / .Selected). Subclass
// default traits are preserved.
self.accessibilityTraits &= ~(UIAccessibilityTraitNotEnabled | UIAccessibilityTraitSelected);
if ([self.accessibilityElement respondsToSelector:@selector(setAccessibilityIdentifier:)]) {
((UIView *)self.accessibilityElement).accessibilityIdentifier = nil;
} else {
self.accessibilityIdentifier = nil;
}
#if !TARGET_OS_TV
if (@available(iOS 13.0, *)) {
self.showsLargeContentViewer = NO;
self.largeContentTitle = nil;
}
#endif
_accessibilityOrderNativeIDs = nil;
self.accessibilityElements = nil;
}

- (void)setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(NSSet<NSString *> *_Nullable)props
Expand Down